Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common: improve the PMEM RAS workflow output #6103

Merged
merged 1 commit into from
Jul 19, 2024
Merged

common: improve the PMEM RAS workflow output #6103

merged 1 commit into from
Jul 19, 2024

Conversation

janekmi
Copy link
Contributor

@janekmi janekmi commented Jul 18, 2024 •
edited by grom72
Loading

  • on failure JSON -> YAML (as it is more human-readable)
  • print the PMDK and pmdk-tests build outputs unconditionally but groupped so it won't consume too much vertical space.
  • remove all ignore_erros: true so no error is ignored

Preview: https://github.com/pmem/pmdk/actions/runs/9992769191/job/27618560250 (🔴 is 🆗 in this case ONLY 😉 )

This change is Reviewable

@janekmi janekmi added sprint goal This pull request is part of the ongoing sprint no changelog Add to skip the changelog check on your pull request labels Jul 18, 2024
@janekmi janekmi requested review from jzarzycki and osalyk July 18, 2024 13:56
@janekmi
common: improve the PMEM RAS workflow output
c4d3b4e 
- on failure JSON -> YAML (as it is more human-readable)
- print the PMDK and pmdk-tests build outputs unconditionally
  but groupped so it won't consume too much vertical space.
- remove all ignore_erros: true so no error is ignored
osalyk
osalyk approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jzarzycki)

jzarzycki
jzarzycki reviewed Jul 19, 2024
View reviewed changes
Copy link

@jzarzycki jzarzycki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@janekmi janekmi merged commit 8700315 into master Jul 19, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzarzycki jzarzycki jzarzycki left review comments

@osalyk osalyk osalyk approved these changes

Assignees
No one assigned
Labels
no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janekmi @jzarzycki @osalyk